[SPARK-31275][WEBUI] Improve the metrics format in ExecutionPage for StageId.#28039
Closed
sarutak wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-31275][WEBUI] Improve the metrics format in ExecutionPage for StageId.#28039sarutak wants to merge 1 commit intoapache:masterfrom
sarutak wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #120436 has finished for PR 28039 at commit
|
Contributor
|
LGTM, cc @tgravescs @gengliangwang |
gengliangwang
approved these changes
Mar 27, 2020
Member
gengliangwang
left a comment
gengliangwang
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
Contributor
|
I'm merging it (master and 3.0) to unblock #28037 , thanks! |
cloud-fan
pushed a commit
that referenced
this pull request
Mar 27, 2020
…StageId ### What changes were proposed in this pull request? In ExecutionPage, metrics format for stageId, attemptId and taskId are displayed like `(stageId (attemptId): taskId)` for now. I changed this format like `(stageId.attemptId taskId)`. ### Why are the changes needed? As cloud-fan suggested [here](#27927 (comment)), `stageId.attemptId` is more standard in Spark. ### Does this PR introduce any user-facing change? Yes. Before applying this change, we can see the UI like as follows.  And after this change applied, we can like as follows.  ### How was this patch tested? Modified `SQLMetricsSuite` and manual test. Closes #28039 from sarutak/improve-metrics-format. Authored-by: Kousuke Saruta <sarutak@oss.nttdata.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit bc37fdc) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…StageId ### What changes were proposed in this pull request? In ExecutionPage, metrics format for stageId, attemptId and taskId are displayed like `(stageId (attemptId): taskId)` for now. I changed this format like `(stageId.attemptId taskId)`. ### Why are the changes needed? As cloud-fan suggested [here](apache#27927 (comment)), `stageId.attemptId` is more standard in Spark. ### Does this PR introduce any user-facing change? Yes. Before applying this change, we can see the UI like as follows.  And after this change applied, we can like as follows.  ### How was this patch tested? Modified `SQLMetricsSuite` and manual test. Closes apache#28039 from sarutak/improve-metrics-format. Authored-by: Kousuke Saruta <sarutak@oss.nttdata.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In ExecutionPage, metrics format for stageId, attemptId and taskId are displayed like
(stageId (attemptId): taskId)for now.I changed this format like
(stageId.attemptId taskId).Why are the changes needed?
As @cloud-fan suggested here,
stageId.attemptIdis more standard in Spark.Does this PR introduce any user-facing change?
Yes. Before applying this change, we can see the UI like as follows.
And after this change applied, we can like as follows.
How was this patch tested?
Modified
SQLMetricsSuiteand manual test.